v.2.6.8 (#4324)

* ci: when build fail will exit the release process (#4319) * fix: on click event on interactive elements (#4322) * chore: deprecated style added to api table * ci(changesets): version packages (#4323) Co-authored-by: Junior Garcia <[email protected]> --------- Co-authored-by: winches <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
heroui-inc · Dec 10, 2024 · 053c1a7 · 053c1a7
2 parents 3f119d9 + 31ab508
commit 053c1a7
Show file tree

Hide file tree

Showing 93 changed files with 638 additions and 1,263 deletions.
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -27,9 +27,18 @@ jobs:
         run: pnpm test
 
       - name: Build
-        run: pnpm build
+        id: build
+        continue-on-error: false
+        # Custom turbo build failure information
+        run: |
+          pnpm build || {
+            echo "Turbo build failed with exit code $?"
+            exit 1
+          }
 
       - name: Create Release Pull Request or Publish to NPM
+        # Run only if the build is successful
+        if: steps.build.outcome == 'success'
         id: changesets
         uses: changesets/action@v1
         with:
@@ -43,7 +52,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Create canary release
-        if: steps.changesets.outputs.published != 'true'
+        if: steps.build.outcome == 'success' && steps.changesets.outputs.published != 'true'
         timeout-minutes: 15
         run: |
           git checkout canary

diff --git a/apps/docs/components/mdx-components.tsx b/apps/docs/components/mdx-components.tsx
@@ -205,9 +205,20 @@ const Link = ({href, children}: {href?: string; children?: React.ReactNode}) =>
   );
 };
 
-const InlineCodeChip = ({children}: {children?: React.ReactNode}) => {
+const InlineCodeChip = ({
+  children,
+  className,
+}: {
+  children?: React.ReactNode;
+  className?: string;
+}) => {
   return (
-    <InlineCode className="before:hidden after:hidden text-tiny rounded-md text-default-600 bg-default-100 dark:bg-default-100/80 px-1.5 py-0.5">
+    <InlineCode
+      className={clsx(
+        "before:hidden after:hidden text-tiny rounded-md text-default-600 bg-default-100 dark:bg-default-100/80 px-1.5 py-0.5",
+        className,
+      )}
+    >
       {children}
     </InlineCode>
   );
@@ -218,6 +229,7 @@ interface APITableProps {
     attribute: string;
     type: string;
     description: string;
+    deprecated?: boolean;
     default?: string;
   }[];
 }
@@ -237,7 +249,9 @@ export const APITable: React.FC<APITableProps> = ({data}) => {
           {data.map((item, index) => (
             <TableRow key={index} className="[&>td]:px-2 [&>td]:py-1.5 [&>td]:first:pt-4">
               <TableCell className="flex items-center gap-1 font-mono text-small whitespace-nowrap">
-                <InlineCodeChip>{item.attribute}</InlineCodeChip>
+                <InlineCodeChip className={item.deprecated ? "line-through" : ""}>
+                  {item.attribute}
+                </InlineCodeChip>
                 {item.description && (
                   <>
                     {/* Desktop tooltip */}

diff --git a/apps/docs/content/docs/components/button.mdx b/apps/docs/content/docs/components/button.mdx
@@ -306,6 +306,7 @@ building buttons that work well across devices and interaction methods.
     },
     {
       attribute: "onClick",
+      deprecated: true,
       type: "MouseEventHandler",
       description: "The native button click event handler (Deprecated) use onPress instead.",
       default: "-"

diff --git a/apps/docs/content/docs/components/dropdown.mdx b/apps/docs/content/docs/components/dropdown.mdx
@@ -772,6 +772,7 @@ you to customize each item individually.
     },
     {
       attribute: "onClick",
+      deprecated: true,
       type: "MouseEventHandler",
       description: "The native button click event handler (**Deprecated**) use **onPress** instead.",
       default: "-"

diff --git a/apps/docs/content/docs/components/link.mdx b/apps/docs/content/docs/components/link.mdx
@@ -275,6 +275,7 @@ In case you need to customize the link even further, you can use the `useLink` h
     },
     {
       attribute: "onClick",
+      deprecated: true,
       type: "MouseEventHandler",
       description: "The native link click event handler (Deprecated) use onPress instead.",
       default: "-"

diff --git a/apps/docs/content/docs/components/listbox.mdx b/apps/docs/content/docs/components/listbox.mdx
@@ -657,6 +657,7 @@ You can customize the `Listbox` items style by using the `itemClasses` prop and
     },
     {
       attribute: "onClick",
+      deprecated: true,
       type: "MouseEventHandler",
       description: "The native button click event handler (Deprecated) use onPress instead.",
       default: "-"

diff --git a/packages/components/accordion/CHANGELOG.md b/packages/components/accordion/CHANGELOG.md
@@ -1,5 +1,12 @@
 # @nextui-org/accordion
 
+## 2.2.5
+
+### Patch Changes
+
+- Updated dependencies [[`78c0928`](https://github.com/nextui-org/nextui/commit/78c09280e30113bd648057ad64ad6198d1e5d58f)]:
+  - @nextui-org/aria-utils@2.2.5
+
 ## 2.2.4
 
 ### Patch Changes

diff --git a/packages/components/accordion/package.json b/packages/components/accordion/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@nextui-org/accordion",
-  "version": "2.2.4",
+  "version": "2.2.5",
   "description": "Collapse display a list of high-level options that can expand/collapse to reveal more information.",
   "keywords": [
     "react",

diff --git a/packages/components/alert/CHANGELOG.md b/packages/components/alert/CHANGELOG.md
@@ -1,5 +1,12 @@
 # @nextui-org/alert
 
+## 2.2.7
+
+### Patch Changes
+
+- Updated dependencies [[`78c0928`](https://github.com/nextui-org/nextui/commit/78c09280e30113bd648057ad64ad6198d1e5d58f)]:
+  - @nextui-org/button@2.2.7
+
 ## 2.2.6
 
 ### Patch Changes

diff --git a/packages/components/alert/package.json b/packages/components/alert/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@nextui-org/alert",
-  "version": "2.2.6",
+  "version": "2.2.7",
   "description": "Alerts are temporary notifications that provide concise feedback about an action or event.",
   "keywords": [
     "alert"

diff --git a/packages/components/autocomplete/CHANGELOG.md b/packages/components/autocomplete/CHANGELOG.md
@@ -1,5 +1,17 @@
 # @nextui-org/autocomplete
 
+## 2.3.7
+
+### Patch Changes
+
+- Updated dependencies [[`78c0928`](https://github.com/nextui-org/nextui/commit/78c09280e30113bd648057ad64ad6198d1e5d58f)]:
+  - @nextui-org/use-aria-button@2.2.3
+  - @nextui-org/aria-utils@2.2.5
+  - @nextui-org/listbox@2.3.7
+  - @nextui-org/button@2.2.7
+  - @nextui-org/popover@2.3.7
+  - @nextui-org/form@2.1.6
+
 ## 2.3.6
 
 ### Patch Changes

diff --git a/packages/components/autocomplete/package.json b/packages/components/autocomplete/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@nextui-org/autocomplete",
-  "version": "2.3.6",
+  "version": "2.3.7",
   "description": "An autocomplete combines a text input with a listbox, allowing users to filter a list of options to items matching a query.",
   "keywords": [
     "autocomplete"

diff --git a/packages/components/button/CHANGELOG.md b/packages/components/button/CHANGELOG.md
@@ -1,5 +1,14 @@
 # @nextui-org/button
 
+## 2.2.7
+
+### Patch Changes
+
+- [#4322](https://github.com/nextui-org/nextui/pull/4322) [`78c0928`](https://github.com/nextui-org/nextui/commit/78c09280e30113bd648057ad64ad6198d1e5d58f) Thanks [@jrgarciadev](https://github.com/jrgarciadev)! - Fix #4292 interactive elements were not responding to "onClick" event
+
+- Updated dependencies [[`78c0928`](https://github.com/nextui-org/nextui/commit/78c09280e30113bd648057ad64ad6198d1e5d58f)]:
+  - @nextui-org/use-aria-button@2.2.3
+
 ## 2.2.6
 
 ### Patch Changes

diff --git a/packages/components/button/__tests__/button.test.tsx b/packages/components/button/__tests__/button.test.tsx
@@ -1,3 +1,4 @@
+import "@testing-library/jest-dom";
 import * as React from "react";
 import {render} from "@testing-library/react";
 import userEvent, {UserEvent} from "@testing-library/user-event";
@@ -35,6 +36,17 @@ describe("Button", () => {
     expect(onPress).toHaveBeenCalled();
   });
 
+  it("should trigger onClick function", async () => {
+    const onClick = jest.fn();
+    const {getByRole} = render(<Button disableRipple onClick={onClick} />);
+
+    const button = getByRole("button");
+
+    await user.click(button);
+
+    expect(onClick).toHaveBeenCalled();
+  });
+
   it("should ignore events when disabled", async () => {
     const onPress = jest.fn();
     const {getByRole} = render(<Button disableRipple isDisabled onPress={onPress} />);

diff --git a/packages/components/button/package.json b/packages/components/button/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@nextui-org/button",
-  "version": "2.2.6",
+  "version": "2.2.7",
   "description": "Buttons allow users to perform actions and choose with a single tap.",
   "keywords": [
     "button"

diff --git a/packages/components/button/src/use-button.ts b/packages/components/button/src/use-button.ts
@@ -56,6 +56,7 @@ interface Props extends HTMLNextUIProps<"button"> {
   /**
    * The native button click event handler.
    * use `onPress` instead.
+   * @deprecated
    */
   onClick?: MouseEventHandler<HTMLButtonElement>;
 }
@@ -150,7 +151,7 @@ export function useButton(props: UseButtonProps) {
       elementType: as,
       isDisabled,
       onPress: chain(onPress, handlePress),
-      onClick: onClick,
+      onClick,
       ...otherProps,
     } as AriaButtonProps,
     domRef,

diff --git a/packages/components/button/stories/button.stories.tsx b/packages/components/button/stories/button.stories.tsx
@@ -71,14 +71,19 @@ const defaultProps = {
 const StateTemplate = (args: ButtonProps) => {
   const [isOpen, setIsOpen] = React.useState(false);
 
-  const handlePress = () => {
+  const handlePress = (e: any) => {
     // eslint-disable-next-line no-console
-    console.log("Pressed");
+    console.log("Pressed", e);
     setIsOpen((prev) => !prev);
   };
 
   return (
-    <Button {...args} aria-label="Open" aria-pressed={isOpen} onPress={handlePress}>
+    <Button
+      {...args}
+      aria-label={isOpen ? "Close" : "Open"}
+      aria-pressed={isOpen}
+      onClick={handlePress}
+    >
       {isOpen ? "Close" : "Open"}
     </Button>
   );

diff --git a/packages/components/calendar/CHANGELOG.md b/packages/components/calendar/CHANGELOG.md
@@ -1,5 +1,13 @@
 # @nextui-org/calendar
 
+## 2.2.7
+
+### Patch Changes
+
+- Updated dependencies [[`78c0928`](https://github.com/nextui-org/nextui/commit/78c09280e30113bd648057ad64ad6198d1e5d58f)]:
+  - @nextui-org/use-aria-button@2.2.3
+  - @nextui-org/button@2.2.7
+
 ## 2.2.6
 
 ### Patch Changes

diff --git a/packages/components/calendar/package.json b/packages/components/calendar/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@nextui-org/calendar",
-  "version": "2.2.6",
+  "version": "2.2.7",
   "description": "A calendar displays one or more date grids and allows users to select a single date.",
   "keywords": [
     "calendar"

diff --git a/packages/components/card/CHANGELOG.md b/packages/components/card/CHANGELOG.md
@@ -1,5 +1,14 @@
 # @nextui-org/card
 
+## 2.2.7
+
+### Patch Changes
+
+- [#4322](https://github.com/nextui-org/nextui/pull/4322) [`78c0928`](https://github.com/nextui-org/nextui/commit/78c09280e30113bd648057ad64ad6198d1e5d58f) Thanks [@jrgarciadev](https://github.com/jrgarciadev)! - Fix #4292 interactive elements were not responding to "onClick" event
+
+- Updated dependencies [[`78c0928`](https://github.com/nextui-org/nextui/commit/78c09280e30113bd648057ad64ad6198d1e5d58f)]:
+  - @nextui-org/use-aria-button@2.2.3
+
 ## 2.2.6
 
 ### Patch Changes

diff --git a/packages/components/card/__tests__/card.test.tsx b/packages/components/card/__tests__/card.test.tsx
@@ -1,10 +1,16 @@
 import * as React from "react";
 import {render} from "@testing-library/react";
-import userEvent from "@testing-library/user-event";
+import userEvent, {UserEvent} from "@testing-library/user-event";
 
 import {Card} from "../src";
 
 describe("Card", () => {
+  let user: UserEvent;
+
+  beforeEach(() => {
+    user = userEvent.setup();
+  });
+
   it("should render correctly", () => {
     const wrapper = render(<Card />);
 
@@ -30,13 +36,22 @@ describe("Card", () => {
 
     const button = getByRole("button");
 
-    const user = userEvent.setup();
-
     await user.click(button);
 
     expect(onPress).toHaveBeenCalled();
   });
 
+  it("should trigger onClick function", async () => {
+    const onClick = jest.fn();
+    const {getByRole} = render(<Card disableRipple isPressable onClick={onClick} />);
+
+    const button = getByRole("button");
+
+    await user.click(button);
+
+    expect(onClick).toHaveBeenCalled();
+  });
+
   it("should render correctly when nested", () => {
     const wrapper = render(
       <Card>

diff --git a/packages/components/card/package.json b/packages/components/card/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@nextui-org/card",
-  "version": "2.2.6",
+  "version": "2.2.7",
   "description": "Card is a container for text, photos, and actions in the context of a single subject.",
   "keywords": [
     "card"

diff --git a/packages/components/card/src/use-card.ts b/packages/components/card/src/use-card.ts
@@ -4,7 +4,7 @@ import type {AriaButtonProps} from "@nextui-org/use-aria-button";
 import type {RippleProps} from "@nextui-org/ripple";
 
 import {card} from "@nextui-org/theme";
-import {ReactNode, useCallback, useMemo} from "react";
+import {MouseEventHandler, ReactNode, useCallback, useMemo} from "react";
 import {chain, mergeProps} from "@react-aria/utils";
 import {useFocusRing} from "@react-aria/focus";
 import {PressEvent, useHover} from "@react-aria/interactions";
@@ -20,7 +20,7 @@ import {ReactRef, filterDOMProps} from "@nextui-org/react-utils";
 import {useDOMRef} from "@nextui-org/react-utils";
 import {useRipple} from "@nextui-org/ripple";
 
-export interface Props extends HTMLNextUIProps<"div"> {
+export interface Props extends Omit<HTMLNextUIProps<"div">, "onClick"> {
   /**
    * Ref to the DOM node.
    */
@@ -34,12 +34,17 @@ export interface Props extends HTMLNextUIProps<"div"> {
    * @default false
    */
   disableRipple?: boolean;
-
   /**
    * Whether the card should allow text selection on press. (only for pressable cards)
    * @default true
    */
   allowTextSelectionOnPress?: boolean;
+  /**
+   * The native button click event handler.
+   * use `onPress` instead.
+   * @deprecated
+   */
+  onClick?: MouseEventHandler<HTMLButtonElement>;
   /**
    * Classname or List of classes to change the classNames of the element.
    * if `className` is passed, it will be added to the base slot.