-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate external packages to internal to avoid version incompatibility #4655
base: canary
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 10c5212 The changes in this PR will be included in the next version bump. This PR includes changesets to release 83 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 199 files out of 281 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
@wingkwong please check build on Vercel |
Closes #4567
📝 Description
Currently users may need to install some external packages. However, since we are using fixed versions for them in HeroUI to avoid unexpected issues, users still may install the latest version (even the doc explicitly defines the exact version). The version incompatibility causes issues from time to time.
This PR is to create a mirror version of the following package so that users will use the exact same version.
@internationalized/date
->@heroui/internationalized-date
@react-aria/i18n
->@heroui/react-aria-i18n
framer-motion
->@heroui/motion
(also migrated tomotion
v12)There three packages will not be included in
@heroui/react
. The reasons are⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
Sort of. Users can still use those 3 packages, but they need to make sure to use the exact version. Otherwise, simply install the package and rename the imports.
@heroui/framer-utils
will be merged to@heroui/motion
📝 Additional Information