Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No password when rebuilding from image #244

Closed
slade991 opened this issue Mar 6, 2023 · 2 comments · Fixed by #245
Closed

No password when rebuilding from image #244

slade991 opened this issue Mar 6, 2023 · 2 comments · Fixed by #245
Assignees
@apricote
Labels
Improvement

Comments

@slade991
Copy link

slade991 commented Mar 6, 2023

Hello,

The hetzner API return the new root password when rebuilding :
Response

actionobject
root_passwordstring – nullable

New root password when not using SSH keys

But hcloud doesn't

Why is that ? Is it possible to get the new root password ?

Thank you.
@apricote apricote self-assigned this Mar 6, 2023
apricote added a commit that referenced this issue Mar 6, 2023
@apricote
feat: add ServerClient.RebuildWithResult to return root password
f93459d 
The existing method Serverclient.Rebuild did not return the root
password and there was no way to add it without breaking API
compatibility.

Closes #244
@apricote apricote mentioned this issue Mar 6, 2023
Merged
apricote added a commit that referenced this issue Mar 6, 2023
@apricote
feat: add ServerClient.RebuildWithResult to return root password (#245)
82f97cf 
* feat: add ServerClient.RebuildWithResult to return root password

The existing method Serverclient.Rebuild did not return the root
password and there was no way to add it without breaking API
compatibility.

Closes #244

* chore: cleanup comments for ServerClient.Delete(WithResult)

- Comment should start with the method name
- Deprecated methods should contain "^Deprecated: xx" in the
  comment
- References to other symbols should use square brackets
@apricote
Copy link
Member

apricote commented Mar 6, 2023

I added a new method ServerClient.RebuildWithResult() that returns the root password in addition to the action. This was released as v1.41.0.

@slade991
Copy link
Author

slade991 commented Mar 6, 2023

Wow. That was fast.
Thanks a ton.

@apricote apricote mentioned this issue Mar 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apricote apricote

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add ServerClient.RebuildWithResult to return root password hetznercloud/hcloud-go
2 participants
@apricote @slade991