-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild does not return root_password #181
Comments
This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs. |
I am not sure if there is a way to fix this without breaking the existing API. The server |
We had this exact issue in
|
This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs. |
Fixes #181 Allow returning a full response during the server rebuild by passing an option to the rebuild method. The main reason for this is to not break user land and give users time to upgrade. We also don't want to introduce a new method `rebuild2` or `rebuild_with_full_response` to keep the API clean. The deprecation timeline is the following: - Introduce the `return_response` argument and deprecated the default behavior (`return_response=False`) - Wait for the next major release to remove the ability to only return the action and deprecated the usage of the `return_response` argument. - Wait for the next+1 major release to fully remove the `return_response` argument, or simply leave it unused.
Bug Report
Current Behavior
'Rebuild' returns the BoundAction but does not return the "root_password"
Input Code
Expected behavior/code
The 'rebuild' should return the root_password along with the BoundAction.
The response from the Hetzner API is below ( See possible solution)
Environment
Possible Solution
Additional context/Screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.
The text was updated successfully, but these errors were encountered: