feat: add has_id_or_name to DomainIdentityMixin
#373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
changed the title
has_id_or_name to DomainIdentityMixinhas_id_or_name to DomainIdentityMixin
jooola
force-pushed
the
DomainIdentityMixin-has_id_or_name
branch
from
fff17d4 to
07c6c24
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
- Coverage 92.86% 92.84% -0.02%
==========================================
Files 65 65
Lines 2872 2881 +9
==========================================
+ Hits 2667 2675 +8
- Misses 205 206 +1 ☔ View full report in Codecov by Sentry. |
jooola
force-pushed
the
DomainIdentityMixin-has_id_or_name
branch
from
07c6c24 to
2b92e44
Compare
apricote
approved these changes
Mar 27, 2024
jooola
pushed a commit
that referenced
this pull request
Mar 27, 2024
🤖 I have created a release *beep* *boop* --- ## [1.34.0](v1.33.3...v1.34.0) (2024-03-27) ### Features * add `has_id_or_name` to `DomainIdentityMixin` ([#373](#373)) ([8facaf6](8facaf6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DomainIdentityMixinto models that were missing it.