Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to report conversion problem? #10

Closed
iapyeh opened this issue Jun 1, 2017 · 3 comments
Closed

How to report conversion problem? #10

iapyeh opened this issue Jun 1, 2017 · 3 comments
Assignees

Comments

@iapyeh
Copy link

iapyeh commented Jun 1, 2017

The kuroshiro.js is an excellent project. Thank you for this great work. Sometime, I encountered tiny issues. For example, "五輪(ごりん)" is converted to "いつわ". I'd like to know how to report this kind of issues, so that eventually we have a more and more perfect kuroshiro.js?

@hexenq hexenq self-assigned this Jun 2, 2017
@hexenq
Copy link
Owner

hexenq commented Jun 2, 2017

Hello, iapyeh. Thanks for using kuroshiro.js. Considering your issue, I have updated the dict files according to kuromoji.js which this project depends on. And it may solve part of your issue (e.g. the "五輪" case).

In addition, you can compile and use a suitable IPA dictionary instead of the default one. (This would be a tough work though...)

By the way, your issue seems to have certain association with morphological analyzation. However, kuroshiro.js mainly focuses on the processing of the results of morphological analyzation while one of the dependency of kuroshiro.js — kuromoji is in charge of morphological analyzation. Therefore at this stage, I could not give you more suggestions. I'm sorry for that. Hope we can find a workaround.😃

@iapyeh
Copy link
Author

iapyeh commented Jun 3, 2017

Thank you very much, it works. By the way, I found another kind of issue different from the above one, like this:
image
(the position "しろ" in the furigana of "面白い言葉")

@hexenq
Copy link
Owner

hexenq commented Jun 5, 2017

Hello iapyeh. I have fixed the bug you mentioned above and published a new version of kuroshiro.js (0.1.5). Have a check. I'll close this issue. Feel free to raise a new issue if you have further more questions.

@hexenq hexenq closed this as completed Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants