Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-ideal results for terms that have kana in between kanji #31

Closed
mistval opened this issue May 23, 2018 · 1 comment
Closed

Non-ideal results for terms that have kana in between kanji #31

mistval opened this issue May 23, 2018 · 1 comment
Assignees
Labels

Comments

@mistval
Copy link

mistval commented May 23, 2018

Hello,

The following code reproduces this problem:

const kuroshiro = require("kuroshiro");
kuroshiro.init(() => {
  console.log(kuroshiro.convert('言い分', {mode: 'furigana'}));
  console.log(kuroshiro.convert('言い訳', {mode: 'furigana'}));
});

It prints:

<ruby>言<rp>(</rp><rt></rt><rp>)</rp></ruby>い<ruby>分<rp>(</rp><rt>いぶん</rt><rp>)</rp></ruby>
<ruby>言<rp>(</rp><rt></rt><rp>)</rp></ruby>い<ruby>訳<rp>(</rp><rt>いわけ</rt><rp>)</rp></ruby>

All the furigana is on the second ruby, and nothing is on the first.

Thanks for the useful package, I'm depending on it here: https://www.npmjs.com/package/render-furigana :)

@hexenq
Copy link
Owner

hexenq commented May 23, 2018

Thanks for using kuroshiro. I've fixed the issue with the latest kuroshiro version 0.2.4. Hava try😄 You're welcome to raise another issue if needed. Closed.

@hexenq hexenq closed this as completed May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants