Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test on 丸の内 gives bad result for romaji passport... #47

Closed
chessyau opened this issue Oct 13, 2018 · 2 comments
Closed

test on 丸の内 gives bad result for romaji passport... #47

chessyau opened this issue Oct 13, 2018 · 2 comments
Assignees
@hexenq
Labels
bug

Comments

@chessyau
Copy link

hiragana-まるのうち
romaji passport-marunochi (should be marunouchi, some how o meet u become o only)
romaji nippon-marunouti
romaji hepburn-marunouchi
@hexenq hexenq added the bug label Oct 16, 2018
@hexenq hexenq self-assigned this Oct 16, 2018
hexenq added a commit that referenced this issue Oct 19, 2018
@hexenq
fix: fix romaji conversion bugs
45a921f 
Closes #46, #47
@hexenq hexenq mentioned this issue Oct 19, 2018
Merged
@hexenq
Copy link
Owner

hexenq commented Oct 19, 2018

Hello @chessyau. Thank you for the feedback. This issue and issue #46 have been solved in the newly released version 1.1.2 of kuroshiro. Check it out😄 And you're welcome to raise another issue if needed. Closed.

@hexenq hexenq closed this as completed Oct 19, 2018
@chessyau
Copy link
Author

Thanks! Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hexenq hexenq

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hexenq @chessyau