Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix it would replace from first 'src' when getting full path of 'kuromoji/dict'. #19

Merged
merged 2 commits into from
Jan 22, 2018

Conversation

deleav
Copy link
Contributor

@deleav deleav commented Nov 24, 2017

If there are multiple 'src' in the full path of 'kuromoji', it would replace from first 'src'.

like this
https://regex101.com/r/zsP8O3/3

fixed
https://regex101.com/r/zsP8O3/2

If there are multiple 'src' in the full path of 'kuromoji', it would replace from first 'src'.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.228% when pulling 0e80703 on deleav:bug/dictionary-not-found into 5f8065c on hexenq:master.

@deleav deleav changed the title Fix bug Fix it would replace from first 'src' when get 'kuromoji/dict' full path. Nov 24, 2017
@deleav deleav changed the title Fix it would replace from first 'src' when get 'kuromoji/dict' full path. Fix it would replace from first 'src' when getting full path of 'kuromoji/dict'. Nov 24, 2017
@hexenq hexenq merged commit 46e2ade into hexenq:master Jan 22, 2018
@hexenq
Copy link
Owner

hexenq commented Jan 22, 2018

Nice work! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants