Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sitemap.xml #25

Closed
wants to merge 13 commits into from
Closed

Update sitemap.xml #25

wants to merge 13 commits into from

Conversation

NoahDragon
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jul 25, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling d2cf164 on #20-with-test into a45bedd on master.

@coveralls
Copy link

coveralls commented Jul 25, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-2.4%) to 97.619% when pulling 7b44c74 on #20-with-test into a45bedd on master.

@coveralls
Copy link

coveralls commented Jul 25, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-2.4%) to 97.619% when pulling 89e9c89 on #20-with-test into a45bedd on master.

@coveralls
Copy link

coveralls commented Jul 25, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-2.4%) to 97.619% when pulling f48bff9 on #20-with-test into a45bedd on master.

@coveralls
Copy link

coveralls commented Jul 25, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling e973cb1 on #20-with-test into a45bedd on master.

@coveralls
Copy link

coveralls commented Jul 25, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 3c8484b on #20-with-test into a45bedd on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-21.4%) to 78.571% when pulling 3c0a691 on #20-with-test into a45bedd on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-21.4%) to 78.571% when pulling 3c0a691 on #20-with-test into a45bedd on master.

@coveralls
Copy link

coveralls commented Jul 25, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling ca503de on #20-with-test into a45bedd on master.

@coveralls
Copy link

coveralls commented Jul 25, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 92815a1 on #20-with-test into a45bedd on master.

@coveralls
Copy link

coveralls commented Jul 25, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 07c7839 on #20-with-test into a45bedd on master.

tomap
tomap previously approved these changes Nov 10, 2018
View reviewed changes
Copy link
Contributor

@tomap tomap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoahDragon NoahDragon dismissed stale reviews from tomap and ghost via 741cac1 November 29, 2018 21:35
@tomap
Copy link
Contributor

tomap commented Nov 30, 2018

Maybe we should close #20 once this PR is merged.
For now, LGTM

@NoahDragon
Copy link
Member Author

@tomap thanks for the reviewing. I will fix the CI errors, and merge it ASAP.

@curbengh
Copy link
Contributor

curbengh commented Jul 1, 2020

#26

@curbengh curbengh closed this Jul 1, 2020
@curbengh curbengh deleted the #20-with-test branch July 1, 2020 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomap tomap tomap left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NoahDragon @coveralls @tomap @curbengh