Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch minimatch to micromatch #57

Merged
merged 1 commit into from
Aug 10, 2019

Conversation

curbengh
Copy link
Contributor

See hexojs/hexo#3538 for more details.

@@ -36,13 +36,5 @@ module.exports = function(locals) {
};

function isMatch(path, patterns) {
if (!patterns) return false;
Copy link
Contributor Author

@curbengh curbengh Jun 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed anymore because skipRenderList won't be null.

@coveralls
Copy link

coveralls commented Jun 29, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 87e5554 on weyusi:micromatch into 5e5ccb0 on hexojs:master.

@curbengh
Copy link
Contributor Author

Depends on Node >=8.

@curbengh
Copy link
Contributor Author

rebased

@curbengh curbengh requested a review from a team August 10, 2019 04:55
Copy link
Contributor

@segayuu segayuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@segayuu segayuu merged commit 45296ad into hexojs:master Aug 10, 2019
@curbengh curbengh deleted the micromatch branch August 11, 2019 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants