revert: feat(highlight): adjust the layout of the highlight code block #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reverts b201c8e
|
Also, we need to merge this PR and release a new version ASAP. Hexo needs a emergency release to include this PR and #147 |
curbengh
approved these changes
Dec 10, 2019
This was referenced Dec 10, 2019
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I just simply revert #132 because #132 introduces just too much Breaking Changes, see discussion at #132 and related issue #145.
IMHO, we should not bring any style changes in highlightjs any more. It will break too much things, especially when we are going to deprecate highlightjs and bring up prismjs.
Hexo has nearly 300 themes, "NexT theme works fine" is just not an enough excuse.
cc @jiangtj @stevenjoezhang @ppoffice