fix(is_external_link): handle invalid url #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to travis ci build, no performance impact detected. |
|
Since it is a widely used packages on npm so I believe it is reliable enough. |
Merged
curbengh
reviewed
Feb 17, 2020
SukkaW
force-pushed
the
fix-is-external-filter
branch
from
d99e87b to
0ace953
Compare
SukkaW
force-pushed
the
fix-is-external-filter
branch
from
0ace953 to
2a9a5ba
Compare
SukkaW
requested review from
a team and
curbengh
and removed request for
curbengh
jiangtj
reviewed
Feb 26, 2020
| let data; | ||
| try { | ||
| data = new URL(input, `http://${sitehost}`); | ||
| } catch (e) { } |
There was a problem hiding this comment.
How about hexo.log.warn(...) to alert the user that there has an invalid URL?
There was a problem hiding this comment.
Since hexo-util has no hexo-log's dependency, there is no way we can use hexo.log.warn in hexo-util.
curbengh
approved these changes
Mar 6, 2020
stevenjoezhang
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details can be found at hexojs/hexo#4130
This PR introduce a try block and treat invalid URL as internal link (return
false).