Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spawn): support string argument #220

Merged
merged 3 commits into from
Jul 23, 2020
Merged

fix(spawn): support string argument #220

merged 3 commits into from
Jul 23, 2020

Conversation

curbengh
Copy link
Contributor

current example uses string argument, so spawn() should support it.
also add array argument and options example.

@coveralls
Copy link

coveralls commented Jul 23, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 97.411% when pulling 5e6d6d6 on curbengh:spawn-string into cd6dcfd on hexojs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 97.411% when pulling 4aa934a on curbengh:spawn-string into cd6dcfd on hexojs:master.

SukkaW
SukkaW previously approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@curbengh curbengh marked this pull request as ready for review July 23, 2020 04:42
@curbengh curbengh requested a review from SukkaW July 23, 2020 04:43
SukkaW
SukkaW approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SukkaW
Copy link
Member

SukkaW commented Jul 23, 2020

BTW, would you mind release a newer version of hexo-util, including all latest changes, for Hexo 5.0.0 release?

@curbengh curbengh merged commit 69865cb into hexojs:master Jul 23, 2020
@curbengh curbengh deleted the spawn-string branch July 23, 2020 06:13
nevilm-lt pushed a commit to nevilm-lt/hexo-util that referenced this pull request Apr 22, 2022
@curbengh @nevilm-lt
Merge pull request hexojs#220 from curbengh/spawn-string
052b0b2 
fix(spawn): support string argument
nevilm-lt pushed a commit to nevilm-lt/hexo-util that referenced this pull request Apr 22, 2022
@curbengh @nevilm-lt
Merge pull request hexojs#220 from curbengh/spawn-string
f37bd7b 
fix(spawn): support string argument
nevilm-lt pushed a commit to nevilm-lt/hexo-util that referenced this pull request Apr 22, 2022
@curbengh @nevilm-lt
Merge pull request hexojs#220 from curbengh/spawn-string
12b0d57 
fix(spawn): support string argument
nevilm-lt pushed a commit to nevilm-lt/hexo-util that referenced this pull request Apr 22, 2022
@curbengh @nevilm-lt
Merge pull request hexojs#220 from curbengh/spawn-string
b2d2e33 
fix(spawn): support string argument
nevilm-lt pushed a commit to nevilm-lt/hexo-util that referenced this pull request Apr 22, 2022
@curbengh @nevilm-lt
Merge pull request hexojs#220 from curbengh/spawn-string
d5072b8 
fix(spawn): support string argument
nevilm-lt pushed a commit to nevilm-lt/hexo-util that referenced this pull request Apr 22, 2022
@curbengh @nevilm-lt
Merge pull request hexojs#220 from curbengh/spawn-string
684674e 
fix(spawn): support string argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curbengh @coveralls @SukkaW