Remove postinstall step #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demurgos
force-pushed
the
issue-24
branch
3 times, most recently
from
2ac21d3 to
d546898
Compare
|
Code LGTM. Could you please remove the package lock json file? |
Use a `prepare` hook instead of a `postinstall` hook to generate the `highlight_alias.json` file. This means that the file is generated during the publication of package to npm or when manually running `npm install` in the project directory. The previous behavior was to generate this step on the consumer side: this was the cause of numerous hard-to-reproduce issues due to the variety of environments. Closes hexojs#20 Closes hexojs#23 Closes hexojs#24
|
@NoahDragon
|
|
Hi, |
|
@demurgos will publish soon. |
|
Thanks 👍 |
|
@demurgos Published. |
|
I confirm that it fixed the issue on my system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a
preparehook instead of apostinstallhook to generatethe
highlight_alias.jsonfile. This means that the file is generatedduring the publication of package to npm or when manually running
npm installin the project directory.The previous behavior was to generate this step on the consumer
side: this was the cause of numerous hard-to-reproduce issues due
to the variety of environments.
Closes #20
Closes #23
Closes #24
Related to hexojs/hexo-cli#23
Related to hexojs/hexo#2095