Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated hashStream #45

Merged
merged 4 commits into from
Nov 5, 2018
Merged

Deprecated hashStream #45

merged 4 commits into from
Nov 5, 2018

Conversation

segayuu
Copy link
Contributor

@segayuu segayuu commented Oct 18, 2018 •
edited
Loading

This PR is divided PR because #35 has become big.

Hash class It itself inherits the Transform class. There is no need to go through HashStream.
In addition, HashStream implementation does not assume objectMode, and objectMode is invalid in Transform options! (It is controlled by readableObjectMode and writableObjectMode)

Since the implementation was originally unclear, you can solve the problem by creating a new createSha1Hash() and migrating it to it.

@segayuu
Add function: createSha1Hash()
3b40dae 
 - deprecated HashStream
    - result for crypto.createHash() is stream
@segayuu
Add test: createSha1Hash
4981588
@segayuu
Update README.md
2bee559
@segayuu segayuu requested a review from a team October 18, 2018 02:12
@coveralls
Copy link

coveralls commented Oct 18, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 96.687% when pulling 8296e97 on segayuu:deprecated-hashStream into c7cb519 on hexojs:master.

NoahDragon
NoahDragon approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@NoahDragon NoahDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@segayuu segayuu merged commit 17a9b7b into hexojs:master Nov 5, 2018
@segayuu segayuu deleted the deprecated-hashStream branch November 5, 2018 01:09
@curbengh curbengh mentioned this pull request Apr 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahDragon NoahDragon NoahDragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@segayuu @coveralls @NoahDragon