feat: add encodeURL() #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curbengh
commented
Sep 2, 2019
SukkaW
approved these changes
Sep 2, 2019
|
@tomap what do you think, in relation to the IDN issue? |
This was referenced Sep 2, 2019
|
Looks good. unit tests seem to cover all cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is stemmed from IDN parsing issue (hexojs/hexo-generator-feed#63). It was later (partially) fixed in hexojs/hexo-generator-feed#82, without encodeURI the root value. Full fix is later proposed in hexojs/hexo-generator-feed#88.
IDN incompatibility is also found in hexo-generator-sitemap and open_graph().
All the proposed fixes actually share similar function, so I propose to put it in hexo-util instead.