-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 1.3.0 #99
Merged
Merged
release: 1.3.0 #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pending #96 |
to clarify (for others reading this), URLs shouldn't be html escaped.
it depends, it should be escaped when displaying as text (see hexojs/hexo#3704), but shouldn't when used for formatting (bold, italic, etc). e.g. <a>How to use the <b> tag?</a>
// should be escaped <a>This is <b>shocking</b>, wow</a>
// shouldn't be escaped which is why there is an option to disable escaping. |
This was referenced Sep 21, 2019
Closed
Closed
SukkaW
approved these changes
Sep 21, 2019
It is possible to encode url in |
#101 merged, I'm merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to include #92 #93 #97 #96 #100 #101
note #93 is a possible breaking change, for an edge case like
<a href="foo.com"><b>text</b></a>
.