Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 1.3.0 #99

Merged
merged 1 commit into from
Sep 22, 2019
Merged

release: 1.3.0 #99

merged 1 commit into from
Sep 22, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Sep 20, 2019

to include #92 #93 #97 #96 #100 #101
note #93 is a possible breaking change, for an edge case like <a href="foo.com"><b>text</b></a>.

@curbengh
Copy link
Contributor Author

Pending #96

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.018% when pulling c127baa on curbengh:1.3.0 into e463a12 on hexojs:master.

@SukkaW
Copy link
Member

SukkaW commented Sep 20, 2019

After #92 #93 and #96, will we cover all edge cases that might happened? I am still worrying about the escape options might break on certain edge cases.

  • Most of the URLs shouldn't be escaped.
  • The html tag inside a html tag shouldn't be escaped.

Anything else?


#96 (comment)

@curbengh
Copy link
Contributor Author

* Most of the URLs shouldn't be escaped.

to clarify (for others reading this), URLs shouldn't be html escaped.

* The html tag inside a html tag shouldn't be escaped.

it depends, it should be escaped when displaying as text (see hexojs/hexo#3704), but shouldn't when used for formatting (bold, italic, etc).

e.g.

<a>How to use the <b> tag?</a>
// should be escaped
<a>This is <b>shocking</b>, wow</a>
// shouldn't be escaped

which is why there is an option to disable escaping.

@curbengh curbengh marked this pull request as ready for review September 21, 2019 12:08
@curbengh curbengh requested a review from a team September 21, 2019 12:09
@curbengh
Copy link
Contributor Author

It is possible to encode url in <style>, #101

@curbengh
Copy link
Contributor Author

#101 merged, I'm merging this.

@curbengh curbengh merged commit 486f4a0 into hexojs:master Sep 22, 2019
@curbengh curbengh deleted the 1.3.0 branch September 22, 2019 08:55
@curbengh
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants