-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: create post with a path composed of numbers throw an error #5117
Conversation
How to testgit clone -b fix_4334 https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test |
There will be an edge case: You can try to change the code here: https://github.com/hexojs/hexo-cli/blob/5c5fc8fe2fc781a557a30f1bf2043502825f173c/lib/hexo.ts#L18 minimist(process.argv.slice(2), { string: ['_', 'p', 'path'] }) should work |
See also hexojs/hexo-cli#200 |
@stevenjoezhang should |
@stevenjoezhang I'm a bit confused, do I just need to add extra test cases in this PR? |
It's tricky to cover this situation with unit tests, need to hook |
Superseded by #5465 |
What does it do?
fix #4334
Screenshots
Pull request tasks