refactor: backslashes on Windows #5457
Merged
+46
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to testgit clone -b windows https://github.com/hexojs/hexo.git
cd hexo
npm install
npm test |
2 tasks
SukkaW
approved these changes
Apr 9, 2024
|
See also hexojs/hexo-util#230 |
stevenjoezhang
added a commit
that referenced
this pull request
Apr 26, 2024
This reverts commit 80dafe2.
stevenjoezhang
added a commit
that referenced
this pull request
Apr 29, 2024
This reverts commit 80dafe2.
stevenjoezhang
added a commit
that referenced
this pull request
May 21, 2024
dimaslanjaka
pushed a commit
to dimaslanjaka/hexo
that referenced
this pull request
Oct 3, 2024
dimaslanjaka
pushed a commit
to dimaslanjaka/hexo
that referenced
this pull request
Oct 3, 2024
This reverts commit 80dafe2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
I have noticed that currently on Windows, paths in Hexo are converted frequently. For example, when adding files to the
ctx.model('Cache')database, the path separators\are replaced with/, and later when Assets use these paths, thejoinfunction is called, which on Windows, will replace/back with\. This pull request aims to standardize the separator in the cache's_idto match the current operating system's support and to avoid using hardcoded separators (usingpath.sepinstead). It will not change existing functionalities but is intended to improve the uniformity and maintainability of the code.WIP: pending #5385Screenshots
Pull request tasks