dnsforward: imp docs

heyxkhoa · Jan 18, 2022 · ca2e5fa · ca2e5fa
1 parent 9ed5f53
commit ca2e5fa
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -29,10 +29,10 @@ TODO(a.garipov): Remove this deprecation, if v0.108.0 is released before the Go
 
 ### Fixed
 
+- Incorrectly invalidated service domains ([#4120]).
 - Poor testing of domain-specific upstream servers ([#4074]).
 - Omitted aliases of hosts specified by another line within the OS's hosts file
   ([#4079]).
-- Incorrectly invalidated service domains ([#4120]).
 
 ### Removed
 

diff --git a/internal/dnsforward/dns.go b/internal/dnsforward/dns.go
@@ -354,6 +354,10 @@ func (s *Server) processRestrictLocal(ctx *dnsContext) (rc resultCode) {
 	if err != nil {
 		log.Debug("dns: parsing reversed addr: %s", err)
 
+		// DNS-Based Service Discovery uses PTR records having not an ARPA
+		// format of the domain name in question.  Those shouldn't be
+		// invalidated.  See http://www.dns-sd.org/ServerStaticSetup.html and
+		// RFC 2782.
 		name := strings.TrimSuffix(q.Name, ".")
 		if err = netutil.ValidateSRVDomainName(name); err != nil {
 			log.Debug("dns: validating service domain: %s", err)