dhcpd: do not panic

heyxkhoa · May 14, 2021 · eb68a21 · eb68a21
1 parent 4236789
commit eb68a21
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/internal/dhcpd/v4.go b/internal/dhcpd/v4.go
@@ -754,6 +754,13 @@ func (s *v4Server) processDecline(req, resp *dhcpv4.DHCPv4) (err error) {
 	newLease, err := s.allocateLease(mac)
 	if err != nil {
 		return fmt.Errorf("allocating new lease for %s: %w", mac, err)
+	} else if newLease == nil {
+		log.Info("dhcpv4: allocating new lease for %s: no more ip addresses", mac)
+
+		resp.YourIPAddr = make([]byte, 4)
+		resp.UpdateOption(dhcpv4.OptMessageType(dhcpv4.MessageTypeAck))
+
+		return nil
 	}
 
 	newLease.Hostname = oldLease.Hostname