Remove Frames Completely

heyxyz · Dec 13, 2024 · d577655 · d577655
1 parent fb4e9a8
commit d577655
Show file tree

Hide file tree

Showing 12 changed files with 4 additions and 4,731 deletions.
diff --git a/apps/api/src/helpers/frames/signFrameAction.ts b/apps/api/src/helpers/frames/signFrameAction.ts
diff --git a/apps/api/src/helpers/oembed/getMetadata.ts b/apps/api/src/helpers/oembed/getMetadata.ts
@@ -7,7 +7,6 @@ import getProxyUrl from "./getProxyUrl";
 import generateIframe from "./meta/generateIframe";
 import getDescription from "./meta/getDescription";
 import getEmbedUrl from "./meta/getEmbedUrl";
-import getFrame from "./meta/getFrame";
 import getImage from "./meta/getImage";
 import getNft from "./meta/getNft";
 import getSite from "./meta/getSite";
@@ -25,7 +24,6 @@ const getMetadata = async (url: string): Promise<null | OG> => {
     const metadata: OG = {
       description: getDescription(document),
       favicon: getFavicon(url),
-      frame: getFrame(document, url),
       html: generateIframe(getEmbedUrl(document), url),
       image: getProxyUrl(image),
       lastIndexedAt: new Date().toISOString(),

diff --git a/apps/api/src/helpers/oembed/meta/getFrame.ts b/apps/api/src/helpers/oembed/meta/getFrame.ts
diff --git a/apps/api/src/routes/frames/post.ts b/apps/api/src/routes/frames/post.ts
diff --git a/apps/api/src/routes/oembed/index.ts b/apps/api/src/routes/oembed/index.ts
@@ -1,4 +1,4 @@
-import { getRedis, setRedis } from "@hey/db/redisClient";
+import { getRedis } from "@hey/db/redisClient";
 import logger from "@hey/helpers/logger";
 import sha256 from "@hey/helpers/sha256";
 import type { Request, Response } from "express";
@@ -35,17 +35,11 @@ export const get = [
         return res.status(200).json({ oembed: null, success: false });
       }
 
-      const skipCache = oembed.frame !== null;
-
-      if (!skipCache) {
-        await setRedis(cacheKey, oembed);
-      }
-
       logger.info(`Oembed generated for ${url}`);
 
       return res
         .status(200)
-        .setHeader("Cache-Control", skipCache ? "no-cache" : CACHE_AGE_1_DAY)
+        .setHeader("Cache-Control", CACHE_AGE_1_DAY)
         .json({ oembed, success: true });
     } catch (error) {
       return catchedError(res, error);