Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to add/skip DMs #207

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Add option to add/skip DMs #207

merged 3 commits into from
Jan 13, 2025

Conversation

volker-fr
Copy link
Contributor

Currently the export option via CLI never shows direct messages. The web app itself shows always direct messages.

This PR:

  • adds the option to show direct messages when exporting into a single file
  • adds the option to hide direct messages when using the web app
  • hides empty private channels, DMs & DM groups in the app.

@volker-fr volker-fr force-pushed the add-dm-option branch 2 times, most recently from b420929 to e1fc1c6 Compare January 1, 2025 00:10
@volker-fr
Copy link
Contributor Author

@hfaran this PR should be good now. With the new template option the feature can now be used out of the box. Please let me know if anything is missing. Thanks.

@hfaran hfaran merged commit eeb7d8e into hfaran:master Jan 13, 2025
2 checks passed
@volker-fr volker-fr deleted the add-dm-option branch January 16, 2025 00:40
@JeffMossMLW
Copy link

Hello. First off, the viewer is a great tool and much appreciated. In the past, I was able to see all DMs along with the public and private channels in Slack using the viewer. It's been awhile since I've needed to pull some info. Now when I run it, I cannot see the DMs. It only shows the public and private channels. I confirmed I am using the ver 2.1.0 and I am not purposefully hiding the DMs when I launch from CMD prompt. I also confirmed the dms.json file is in the zipped folder and it will open via browser. Any help would be greatly appreciated!

@volker-fr
Copy link
Contributor Author

I created a fix for this this issue: #217

@JeffMossMLW
Copy link

Thanks! I upgraded to the ver 3.0.0. But the same issue occurs. The left sidebar navigation only shows public and private channels. No DM list or Group DM list. I see the dms.json file, but nothing shows up.
image

@volker-fr
Copy link
Contributor Author

Accidentally copied the cli default over. PR to restore backward compatibility: #218

Workaround for 3.0.0 is to use --show-dms. I verfied this locally via python3 app.py -z ../myexport --show-dms.

There have been recently a few more feature flags, too. They might -- or might not -- be of interest. slack-export-viewer --help should show those and also the env var's tied to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants