-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mutated type in Quantity #509
Labels
Comments
Hi. |
Revisit after #905 |
This was referenced Dec 10, 2019
I am closing this as it is taken care by #925 |
4 tasks
bors bot
added a commit
that referenced
this issue
Dec 27, 2019
957: Add parameterized test for type immutability r=hgrecco a=jthielen As discussed in #925, this adds a parameterized test to verify that the internal type is not mutated under common operations (as encountered in #399, #481, #509, #622, #678). - [x] Closes #925, Closes #481 - [x] Executed ``black -t py36 . && isort -rc . && flake8`` with no errors - [x] The change is fully covered by automated unit tests - ~~Documented in docs/ as appropriate~~ - [x] Added an entry to the CHANGES file Co-authored-by: Jon Thielen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If I do a
np.shape
over a Quantity, the operation mutates the type of the.magnitude
See the example below :
The text was updated successfully, but these errors were encountered: