Add case (in)senstive option to registry

[jthielen]

Implements the case sensitive registry option discussed in #1145

• Closes Add case (in)senstive option to registry and extend to Unit and Quantity parsing #1145
• Executed black -t py36 . && isort -rc . && flake8 with no errors
• The change is fully covered by automated unit tests
• Documented in docs/ as appropriate
• Added an entry to the CHANGES file

[hgrecco]

This looks good. Just one question. Why you decided to put the

case_sensitive = (
            self.case_sensitive if case_sensitive is None else case_sensitive
        )

in parse_unit_name and not in _parse_unit_name?

[jthielen]

Why you decided to put the ... in parse_unit_name and not in _parse_unit_name?

I believe that was because I started with it at the highest level (in each public function with the case_sensitive kwarg), and then realized that they all ended up being routed through parse_unit_name, so that was the only one needed. Indeed, I can move it to _parse_unit_name just as well. Let me know if you'd want me to move it there or not.

[hgrecco]

I think it makes sense to put it in _parse_unit_name so that any future method that uses internal functions can rely on that and avoid code duplication.

[jthielen]

I think it makes sense to put it in _parse_unit_name so that any future method that uses internal functions can rely on that and avoid code duplication.

Sounds good, the change has been made. Thanks!

[hgrecco]

bors r+

[bors]

Build succeeded:

• continuous-integration/travis-ci/push