WIP: Add matmul ufunc with support for @ operator #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthielen
force-pushed
the
add-matmul-ufunc
branch
2 times, most recently
from
066a175 to
b872544
Compare
jthielen
changed the title
|
Changed to WIP, since I need to dig into the Travis failures more, which I haven't been able to replicate locally. |
jthielen
force-pushed
the
add-matmul-ufunc
branch
from
b872544 to
a053a5c
Compare
Adds support for __matmul__ and __rmatmul__ (@) operator, by way of numpy matmul ufunc (only supported in Python >= 3.5). Includes workaround for np.matmul returning units in numpy > 1.15 and not in numpy <= 1.15. Closes hgrecco#859
jthielen
force-pushed
the
add-matmul-ufunc
branch
from
a053a5c to
11ddbfa
Compare
|
There appears to be inconsistent behavior with |
|
Closed in favor of implementation in #905. |
jthielen
added a commit
to jthielen/pint
that referenced
this pull request
Dec 5, 2019
jthielen
added a commit
to jthielen/pint
that referenced
this pull request
Dec 5, 2019
jthielen
added a commit
to jthielen/pint
that referenced
this pull request
Dec 5, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
__matmul__and__rmatmul__(the@operator), by way of numpymatmulufunc.I'm not sure if the tests belong with the issues tests, or the ufunc tests. If you'd like me to move them to the ufunc tests, just let me know.
Closes #859.