Update documentation to address MaskedArray breaking change #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 31, 2019
966: Update documentation to address MaskedArray breaking change r=hgrecco a=jthielen As discussed in #963 (comment), #963 introduced a breaking change with MaskedArrays with the implementation of `__array_ufunc__` on Unit. This PR documents this breaking change as prompted by #963 (comment) (with the hope that numpy/numpy#15200 can be resolved soon!) - ~~Closes # (insert issue number)~~ - [x] Executed ``black -t py36 . && isort -rc . && flake8`` with no errors - ~~The change is fully covered by automated unit tests~~ (documentation update only) - [x] Documented in docs/ as appropriate - [x] Added an entry to the CHANGES file Co-authored-by: Jon Thielen <[email protected]>
Build succeededAnd happy new year from bors! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #963 (comment), #963 introduced a breaking change with MaskedArrays with the implementation of
__array_ufunc__on Unit. This PR documents this breaking change as prompted by #963 (comment) (with the hope that numpy/numpy#15200 can be resolved soon!)Closes # (insert issue number)black -t py36 . && isort -rc . && flake8with no errorsThe change is fully covered by automated unit tests(documentation update only)