Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the ability to specify number #43

Merged
merged 4 commits into from
Dec 4, 2022
Merged

add the ability to specify number #43

merged 4 commits into from
Dec 4, 2022

Conversation

hh-h
Copy link
Owner

@hh-h hh-h commented Sep 11, 2022

No description provided.

@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Base: 85.11% // Head: 85.37% // Increases project coverage by +0.25% 🎉

Coverage data is based on head (150a3a8) compared to base (c670479).
Patch coverage: 95.23% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   85.11%   85.37%   +0.25%     
==========================================
  Files           9        9              
  Lines         524      540      +16     
==========================================
+ Hits          446      461      +15     
- Misses         78       79       +1     
Impacted Files Coverage Δ
aiosnmp/snmp.py 98.13% <92.30%> (-0.83%) ⬇️
aiosnmp/__init__.py 100.00% <100.00%> (ø)
aiosnmp/message.py 78.30% <100.00%> (+0.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stsojithomas
Copy link

@hh-h Sorry for the delayed response.
Validated int, gauge32, and string in various combinations, and they work. No changes needed to the encoder as when we pass the appropriate tag, the device accepts the value.

The code may be merged and dist built.

Thank you!

@hh-h hh-h merged commit 365b3c8 into master Dec 4, 2022
@hh-h hh-h deleted the gauge branch December 4, 2022 05:11
@hh-h
Copy link
Owner Author

hh-h commented Dec 5, 2022

@stsojithomas 0.7.2 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants