forked from Qiskit/qiskit-aer
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Resolve regression from introduction of AER::Config (Qiskit#1747)
This commit reduces redundant copy in `AER::Transpile::CircuitOptimization`. Since 0.12.0, configuration is `AER::Config` instead of `json_t`. This new class has many fields and then its copy overheads become high. Reduction of redundant copy improves performance especially for low-qubit simulation.
- Loading branch information
Showing
3 changed files
with
10 additions
and
5 deletions.
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
releasenotes/notes/avoid_copy_of_config-7f7891864c1a1bd0.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
fixes: | ||
- | | ||
Performance regression due to introduction of ``AER::Config`` is fixed. | ||
This class has many fields but is frequently copied in ``AER::Transpile::CircuitOptimization``. | ||
Originally ``json_t`` (former class for configuration) was also frequently copied but | ||
it does have entries in most cases and then this copy overhead is not a problem. | ||
With this fix, ``AER::Transpile::CircuitOptimization`` does not copy ``AER::Config``. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters