Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

使用black做代码格式化 #1675

Merged
merged 3 commits into from
Jul 15, 2022
Merged

使用black做代码格式化 #1675

merged 3 commits into from
Jul 15, 2022

Conversation

hhyo
Copy link
Owner

@hhyo hhyo commented Jul 13, 2022

action增加代码格式化检测

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #1675 (3d55089) into master (0dbba0e) will decrease coverage by 0.00%.
The diff coverage is 61.48%.

❗ Current head 3d55089 differs from pull request most recent head 33ded63. Consider uploading reports for the commit 33ded63 to get more accurate results

@@            Coverage Diff             @@
##           master    #1675      +/-   ##
==========================================
- Coverage   76.20%   76.20%   -0.01%     
==========================================
  Files          91       91              
  Lines       14306    14307       +1     
==========================================
  Hits        10902    10902              
- Misses       3404     3405       +1     
Impacted Files Coverage Δ
common/utils/const.py 100.00% <ø> (ø)
common/utils/permission.py 37.03% <0.00%> (ø)
common/workflow.py 22.50% <0.00%> (ø)
sql/aliyun_rds.py 10.98% <0.00%> (ø)
sql/engines/tests.py 99.77% <ø> (ø)
sql/templatetags/format_tags.py 65.00% <0.00%> (ø)
sql/user.py 58.33% <0.00%> (ø)
sql/utils/sql_utils.py 63.08% <ø> (ø)
sql/utils/ssh_tunnel.py 33.33% <ø> (ø)
sql/utils/tasks.py 85.18% <ø> (ø)
... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dbba0e...33ded63. Read the comment docs.

增加代码格式化检测
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 17 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 17 potential problems in the proposed changes. Check the Files changed tab for more details.

@LeoQuote
Copy link
Collaborator

一万多行, 哈哈

@LeoQuote
Copy link
Collaborator

最好加一个脚本方便本地跑

@hhyo
Copy link
Owner Author

hhyo commented Jul 14, 2022

一万多行, 哈哈

二开的合并的上么😂@nick2wang @weideguo

@hhyo
Copy link
Owner Author

hhyo commented Jul 14, 2022

最好加一个脚本方便本地跑

black ./

@nick2wang
Copy link
Collaborator

看了下大部分是对单引号字符串格式化为双引号,black应该可以配置跳过这个检查项,毕竟在pep8规范里使用单引号是合规(不愧是一点都不妥协的black:joy:)

@LeoQuote
Copy link
Collaborator

感觉双引号可以有, 没必要忽略的样子

@weideguo
Copy link
Collaborator

一万多行, 哈哈

二开的合并的上么😂@nick2wang @weideguo

我没什么问题,可以使用主分支

@hhyo hhyo merged commit 2fa4738 into master Jul 15, 2022
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 17 potential problems in the proposed changes. Check the Files changed tab for more details.

@LeoQuote LeoQuote deleted the lint branch July 17, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants