-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update to remix vite #519
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-ogawa
commented
Nov 12, 2023
hi-ogawa
force-pushed
the
refactor-remix-vite
branch
from
November 12, 2023 01:52
6875b49
to
8883f0e
Compare
hi-ogawa
changed the title
refactor: integrate remix vite
refactor: update to remix vite
Nov 12, 2023
This comment was marked as resolved.
This comment was marked as resolved.
hi-ogawa
commented
Nov 16, 2023
This was referenced Nov 20, 2023
hi-ogawa
commented
Nov 24, 2023
hi-ogawa
force-pushed
the
refactor-remix-vite
branch
from
December 4, 2023 03:53
1cc0717
to
20c7570
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic idea is:
import * as build from "virtual:server-entry
directly and use withcreateRequestHandler
like before (and use as hattip handler)next
call is not wrapped by async context https://github.com/hattipjs/hattip/blob/37f824115c85ef96f6e2b28cfe289f882f225c73/packages/adapter/adapter-node/src/common.ts#L93-L98@vavite/connect
TODO: is explicitthis is finemoduleGraph.invalidateModule
necessary for virtual modules on ssr?vite-plugin-ssr-middleware
vite-plugins#116todo
uno.css
infinite update (probably same issue as (reproduction) chore: infinite hot unocss reproduction vite-plugins#12)import "virtual:uno.css"
fromentry.client.tsx
toroot.tsx
fixed itvitePluginSsrCss
vite-plugins#110)handle
?remix
doesn't include it in whitelist https://github.com/hi-ogawa/remix/blob/bf2feb9bdb292ac6560964d6749b0fcf9a8c784e/packages/remix-dev/vite/plugin.ts#L957waitForHydration
, but still flaky even after retry...)vite build
.6.6MB
to4.3MB
?plugin 'unocss:transformers:pre' uses deprecated 'enforce' option. Use 'order' option instead
app/entry-ui-dev.tsx
?DEBUG="vite:transform" pnpm dev
(slow startup is due to child compiler?)