Backport HHH-14828 to branch 5.4 - Bytecode enhancement generates invalid bytecode for final fields #4237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sanne Could you please confirm it's fine to backport this to 5.4? |
We need to remove the final modifier if we want to address the possibility of that field being lazy.
yrodiere
force-pushed
the
HHH-14828-5.4
branch
from
91390d8 to
f2c7fe7
Compare
yes it's fine but I wouldn't rush it for non-trivial patches. WDYT of leaving this here for a couple weeks and see feedback from 5.5+? |
|
Works for me. But I'll bet we will just forget about it :D Let's find out! |
|
merged - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-14828
Backport of #4231
I did not intend to backport this initially, but I think it will be necessary to fix quarkusio/quarkus#20186 in old versions of Quarkus.