HV-1840 Drop/replace deprecated CDI API usages #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins add this person to the trusted builders? (reply with: "add to whitelist" or "ok to test") |
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
gsmet
changed the title
|
Thanks Matej! I'll wait for CI and merge. |
|
@manovotn let me know if you need a release. |
|
Actually, if that release would then bubble all the way up to wfly, it would be a nice step towards testing some EE 10 changes in-container. |
|
@manovotn cough cough. Sorry I only thought about this one again recently and saw your message then. I released 7.0.2.Final today and it contains these changes. |
|
Haha, no problem @gsmet :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing WFLY with latest CDI API (4.0.0.Alpha1) where there was a number of removals of long deprecated methods.
See jakartaee/cdi#472
This causes hibernate validator to crash during TCK runs so I had to create a custom artifact and replace it within WFLY - this PR a sum of changes I needed to make it work.
Since you are bound to eventually bounce into the very same issue, I thought I might as well contribute. But whether you accept it or not is OFC completely up to you :-)
Oh and I should note - the current state of this PR will work with CDI 2/3 as well as CDI 4 so there should be no harm in having it applied right away.