4.3.2.final patch #330
4.3.2.final patch #330
Conversation
…perations publicly accessible
|
@gunnarmorling any chance you can run this version with a security manager enabled? |
|
HV-5-MASTER #514 FAILURE |
| * | ||
| * @return the member which matching the name and type or {@code null} if no such member exists. | ||
| */ | ||
| public static Member getMember(Class<?> clazz, String property, ElementType elementType) { |
There was a problem hiding this comment.
This should not be public.
Makes sense. I had moved it to reduce some visibilities but we cannot do it in 4.3 as we don't have the IF/class split for it there. |
| } | ||
|
|
||
| public BeanConstraintLocation getLocation() { | ||
| return (BeanConstraintLocation) super.getLocation(); | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Interesting, was this part of the original change? Not that it does harm, just wondering.
There was a problem hiding this comment.
it was directly added by your changes, but the version on 4.3 did not have an equals at all. I thought it would not harm. On the other hand hashCode is missing, so I probably just get rid of it altogether.
Yes, I'll give it a try. |
|
I'm seeing one permission issue, but I'm not totally clear about the cause. That's not required on master. I'm wondering whether it's related to that special classloader which is used in the 1.0 TCK. Does this ring a bell in any way? |
|
Pushed a forced update to apply review comments |
|
HV-5-MASTER #517 FAILURE |
|
One more test is failing when running with a security manager, |
Not really. Obviously the harness is executed differently. On the 4.3 branch is was something homegrown and on master it is Arquillian. How do you run the tests? In container or not? |
I remember vaguely.
I see how hard it is to apply.
Sure. Let me have a quick look. |
|
I added a commit with the HV-843 backport. @gunnarmorling, could you check again? |
|
HV-5-MASTER #518 FAILURE |
…marshal() into privileged actions
…ying handling of annotation member value handling.
|
@hferentschik, Ah you pushed another update with the JAXB fix already, right? |
yes |
|
HV-5-MASTER #521 FAILURE |
|
thanks. |
For 4.3.2 I only applied the HV-912 changes. I did not move
ConstraintMappingas on master (part of the "reducing accessibility of some classes and methhods". I think it is technically not necessary and it could break existing clients. @gunnarmorling, wdyt?