Token launcher for home page #10447
Token launcher for home page #10447
Conversation
| @@ -317,6 +320,13 @@ const CommonDomainRoutes = ({ | |||
| // GOVERNANCE END | |||
|
|
|||
| // DISCUSSIONS | |||
| <Route | |||
| key="/:scope/community-home" | |||
There was a problem hiding this comment.
is this product decision that we will access the page with this URL like dydx/community-home? For me it does not look good. for me home page should be just /dydx or dydx/dashboard or something. Please consult it with product
There was a problem hiding this comment.
probably we should also add it to custom domain routes
| @@ -113,6 +118,31 @@ export const DiscussionSection = ({ | |||
| localStorage[`${app.activeChainId()}-discussions-toggle-tree`], | |||
| ); | |||
| const discussionsGroupData: SectionGroupAttrs[] = [ | |||
| { | |||
| title: 'Community Home', | |||
There was a problem hiding this comment.
shouldn't we add it behind the feature flag?
| modeOfManageCommunityStakeModal, | ||
| } = useManageCommunityStakeModalStore(); | ||
|
|
||
| const [selectedCommunityId] = useState<string>(); |
There was a problem hiding this comment.
I dont thing this needs to be in state. Or it will be modified in the upcoming prs?
| } | ||
| /> | ||
| } | ||
| // @ts-expect-error <StrictNullChecks/> |
There was a problem hiding this comment.
please avoid using StrictNullChecks everywhere
|
I have similar feedback as Marcin. Also noticed a minor thing, the token card is a bit cutof from the side. 
Functionality-wise, LGTM, but lets work on the other suggestions above. |
Link to Issue
Closes: #10266
Description of Changes
"How We Fixed It"
Test Plan
Deployment Plan
Other Considerations