-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kaleem neslit.10553.profile page UI update #10604
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this was part of this pr or it is regression but:
- upvote component does not show correct number of upvotes (0 vs 1 in thread)
- when you click upvote, app ask me to sign in even though I am sign in
- If I click outside the modal, I am moved to the thread anyways
@masvelio after speaking with @sssssabinaaa we decided to remove the ability to upvote within the profile thread, which solves your above requested fixes. This also goes along with Kaleem's comment in |
@Israellund what is remains in this PR . do i need to implement some other task here . |
@KaleemNeslit I'm going to finish this today, just making the comments look like the threads at Dillon's request. Making a new ProfileComment component to match ProfileThread. |
Link to Issue
Closes: #10553
Description of Changes
-updated the Ui for thread tab
"How We Fixed It"
-updated the Ui for thread tab
Test Plan