Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaleem neslit.10553.profile page UI update #10604

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

KaleemNeslit
Copy link
Collaborator

Link to Issue

Closes: #10553

Description of Changes

  • Updated the ui for profile page
  • updated the ui for comments Tab
    -updated the Ui for thread tab

"How We Fixed It"

  • Updated the ui for profile page
  • updated the ui for comments Tab
    -updated the Ui for thread tab

Test Plan

  • login in commonWealth
  • userProfile click button from top right menu bar
  • from dropdown select view profile

Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this was part of this pr or it is regression but:

  1. upvote component does not show correct number of upvotes (0 vs 1 in thread)
  2. when you click upvote, app ask me to sign in even though I am sign in
  3. If I click outside the modal, I am moved to the thread anyways

@Israellund
Copy link
Collaborator

@masvelio after speaking with @sssssabinaaa we decided to remove the ability to upvote within the profile thread, which solves your above requested fixes. This also goes along with Kaleem's comment in ProfileThread.tsx of canUpdateThread={false} // we dont want user to update thread from here, even if they have permissions

@KaleemNeslit
Copy link
Collaborator Author

@Israellund what is remains in this PR . do i need to implement some other task here .

@Israellund
Copy link
Collaborator

@KaleemNeslit I'm going to finish this today, just making the comments look like the threads at Dillon's request. Making a new ProfileComment component to match ProfileThread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Profile Page Display
3 participants