Fixes referrals flow with new event attributes #10658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbennettcw
approved these changes
Jan 17, 2025
masvelio
approved these changes
Jan 21, 2025
kurtassad
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
@Rotorsoft Just tested now, adding a new event to the ABI will not break existing parsing. We can merge this PR in, but we will need to remember to update the DeployedNamespace event when Ege is ready to launch to mainnet.
Also note that it will not actually work until the contract with the DeployedNamespaceWithReferral is actually deployed to mainnet, because until then, no events of this type will be emit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #10657
Description of Changes
Test Plan