Fix collaborators modal (add + delete editors) #3058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where the thread collaborators modal did not properly add editors. Also ensures that it can properly delete editors.
Link to Issue
Closes: #3008
Description of Changes
addEditor
anddeleteEditor
endpointsTest Plan
Deployment Plan
N/A
Other Considerations
I noticed that when updating partial state, there are instances of mutating the state directly like this:
It's generally not good practice to mutate state directly, but since
Thread
is a class and not a plain object, we can't use the spread operator. As a result, we'll need to continue applying the mutation pattern. Just an FYI though I'm sure we all know this already.