Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search pagination + other fixes #3451

Merged
merged 29 commits into from
Apr 19, 2023
Merged

Add search pagination + other fixes #3451

merged 29 commits into from
Apr 19, 2023

Conversation

rbennettcw
Copy link
Contributor

@rbennettcw rbennettcw commented Apr 13, 2023

Link to Issue

Closes: #3449
Closes: #3404
Closes: #3406

Description of Changes

  • Adds pagination for search pages (threads, replies)
  • Fixed malformed URI sort bug
  • Fixes issue with comment search results not showing full search text

Test Plan

  • From the home page (unscoped), search for a popular term and submit to see the search results page
  • Scroll to the bottom and confirm that new results are loaded when bottom is reached (infinite scroll)
  • Switch tabs, confirm that tab is updated and URL is updated with tab name
  • Navigate to a tabbed URL (http://localhost:8080/search?q=amazing&chainScope=all_chains&sort=Best&tab=Replies) – confirm that the page initializes on the Replies tab
  • Repeat steps from beginning, for a specific scope (e.g. dydx, Ethereum)

Deployment Plan

N/A

Other Considerations

N/A

@masvelio masvelio added the React label Apr 14, 2023
@jnaviask jnaviask changed the base branch from react to master April 14, 2023 23:47
@rbennettcw rbennettcw marked this pull request as ready for review April 18, 2023 19:34
@rbennettcw rbennettcw requested a review from jnaviask as a code owner April 18, 2023 19:34
@jnaviask
Copy link
Collaborator

Getting an error when I click from the "threads" to the "replies" tab:

GET /api/searchDiscussions?chain=dydx&search=great&page_size=6&sort=Best 200 34.894 ms - -
Error: Named bind parameter "$chains" has no value in the given object.

@rbennettcw
Copy link
Contributor Author

@jnaviask Fixed chain bug.

Copy link
Collaborator

@jnaviask jnaviask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@jnaviask jnaviask merged commit 5344fdb into master Apr 19, 2023
@jnaviask jnaviask deleted the ryan.search-pagination branch April 19, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants