Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor transaction flows to allow modifications of individual transactions #1229

Open
0xivanov opened this issue Jan 20, 2025 · 0 comments
Assignees

Comments

@0xivanov
Copy link
Contributor

0xivanov commented Jan 20, 2025

Description

Currently, the TokenRejectFlow class and similar transaction flows are overly reliant on class hierarchies that treat flows as if they are transactions themselves. This design complicates the implementation and maintenance of transaction flows.

To improve this, we should refactor transaction flows so that transactions are treated as members of the flows rather than flows inheriting from transactions. This approach will simplify the design by:

  1. Avoiding the need to reimplement selectors, mutators, and other functionality whenever creating new flows.
  2. Allowing individual transactions within a flow to be modified independently (e.g., setting specific execution or transaction parameters).

References

@0xivanov 0xivanov added this to the v2.55.0 milestone Jan 20, 2025
@0xivanov 0xivanov self-assigned this Jan 27, 2025
@0xivanov 0xivanov removed this from the v2.55.0 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant