feat: POC refactor for TokenRejectFlow #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gsstoykov <[email protected]>
rwalworth
reviewed
Jan 14, 2025
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Introduces an example improvement to
TokenRejectFlowclass. There is no need to create overcomplicated class hierarchies as Flows are not Transactions themselves so that approach would be hurtful to our design. Instead I decided that we can just hold transactions themselves as members of the flows and this way we won't have to reimplement existing selectors/mutators and etc. every time we have to create a flow. Also this way we can treat every transaction individually meaning that we can freely set execution and transaction parameters.Related issue(s):
Fixes #822
Notes for reviewer:
Checklist