Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add recursive lint and fix linting issues in the tck folder #1243

Merged
merged 13 commits into from
Feb 6, 2025
Merged

ci: Add recursive lint and fix linting issues in the tck folder #1243

merged 13 commits into from
Feb 6, 2025

Conversation

gsstoykov
Copy link
Contributor

@gsstoykov gsstoykov commented Feb 4, 2025 •
edited
Loading

Description:
Introduces:

  • Job for TCK build and lint
  • Fixed a couple of lint issues in the TCK. Some of the lint issues require reworking logic in the TCK methods so I currently set them as //nolint and a follow-up task will be required.

Related issue(s):

Fixes #1206

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@gsstoykov gsstoykov self-assigned this Feb 4, 2025
@gsstoykov gsstoykov linked an issue Feb 4, 2025 that may be closed by this pull request
Add CI Vet and Lint for TCK project #1206
Closed
@codecov Codecov
Copy link

codecov bot commented Feb 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

@gsstoykov gsstoykov marked this pull request as ready for review February 6, 2025 09:31
@gsstoykov gsstoykov requested review from a team as code owners February 6, 2025 09:31
@gsstoykov gsstoykov force-pushed the 1206-add-ci-vet-and-lint-for-tck-project branch from e5e9716 to a35d8c0 Compare February 6, 2025 10:29
@gsstoykov gsstoykov force-pushed the 1206-add-ci-vet-and-lint-for-tck-project branch from c92a8e1 to 16e448a Compare February 6, 2025 10:49
0xivanov
0xivanov reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🦖

.github/workflows/build.yml Outdated Show resolved Hide resolved
@gsstoykov
ci: Add TCK unit tests
db7ee4b 
Signed-off-by: gsstoykov <[email protected]>
0xivanov
0xivanov approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsstoykov gsstoykov merged commit 200c7b3 into main Feb 6, 2025
9 checks passed
@gsstoykov gsstoykov deleted the 1206-add-ci-vet-and-lint-for-tck-project branch February 6, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xivanov 0xivanov 0xivanov approved these changes

Assignees

@gsstoykov gsstoykov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CI Vet and Lint for TCK project
2 participants
@gsstoykov @0xivanov