Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HIP-991): Permissionless revenue topics #1250

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Feb 7, 2025

This HIP introduces new transactions and updates to existing transactions in the consensus node software. SDKs will need to support these new transactions and updates to existing ones so that developers can take advantage of the new features.

  • Implementation
  • Unit tests
  • E2E tests
  • Example

Fixes: #1082

Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
@0xivanov 0xivanov added the enhancement New feature or request label Feb 7, 2025
@0xivanov 0xivanov self-assigned this Feb 7, 2025
@0xivanov 0xivanov marked this pull request as ready for review February 12, 2025 15:11
@0xivanov 0xivanov requested review from a team as code owners February 12, 2025 15:11
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Base automatically changed from update-protobufs-to-v.0.59 to main February 13, 2025 15:16
Signed-off-by: Ivan Ivanov <[email protected]>
…s-for-Topic-Operators' of https://github.com/hiero-ledger/hiero-sdk-go into 1082-HIP-991-Permissionless-revenue-generating-Topic-IDs-for-Topic-Operators
@0xivanov 0xivanov requested review from a team as code owners February 14, 2025 10:33
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 87.80488% with 35 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
sdk/topic_info.go 46.66% 16 Missing ⚠️
sdk/topic_update_transaction.go 90.36% 8 Missing ⚠️
sdk/custom_fee_limit.go 88.88% 4 Missing and 2 partials ⚠️
sdk/custom_fixed_fee.go 86.36% 2 Missing and 1 partial ⚠️
sdk/custom_royalty_fee.go 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
sdk/topic_create_transaction.go 98.45% <100.00%> (+0.89%) ⬆️
sdk/topic_message_submit_transaction.go 82.17% <100.00%> (+2.17%) ⬆️
sdk/transaction.go 69.77% <100.00%> (+0.26%) ⬆️
sdk/custom_royalty_fee.go 55.40% <0.00%> (ø)
sdk/custom_fixed_fee.go 72.38% <86.36%> (+8.01%) ⬆️
sdk/custom_fee_limit.go 88.88% <88.88%> (ø)
sdk/topic_update_transaction.go 86.77% <90.36%> (+1.14%) ⬆️
sdk/topic_info.go 39.13% <46.66%> (+4.20%) ⬆️

... and 4 files with indirect coverage changes

Signed-off-by: Ivan Ivanov <[email protected]>
…ng-Topic-IDs-for-Topic-Operators

Signed-off-by: Ivan Ivanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HIP-991: Permissionless revenue-generating Topic IDs for Topic Operators
1 participant