Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print group in jobname #8

Conversation

fibbers
Copy link

@fibbers fibbers commented Aug 17, 2015

No description provided.

A Rundeck job can fail before any nodes have failed.
This causes an exception:

	> Caused by: freemarker.core.InvalidReferenceException: The following has evaluated to null or missing:
	> ==> executionData.failedNodeListString  [in template "slack-incoming-message.ftl" at line 39, column 27]
	>
	> Tip: If the failing expression is known to be legally null/missing, either specify a default value with myOptionalVar!myDefault, or use <#if myOptionalVar??>when-present<#else>when-missing</#if>. (These only cover the last step of the expression; to cover the whole expression, use parenthessis:
	> (myOptionVar.foo)!myDefault, (myOptionVar.foo)??
	>
	> The failing instruction:
	> ==> ${executionData.failedNodeListString}  [in template "slack-incoming-message.ftl" at line 39, column 25]
	> 	at freemarker.core.InvalidReferenceException.getInstance(InvalidReferenceException.java:98)
	> ...

This prevents the notification from being sent, so print a default message
instead.
We have several groups containing jobs with equal names, e.g.

group1:
  - update
  - restart
group2:
  - update
  - restart

In Slack we can now differentiate between the jobs: "Execution #246 of group1/update"
instead of just: "Execution #246 of update"
sawanoboly added a commit that referenced this pull request Aug 18, 2015
@sawanoboly sawanoboly merged commit 797272a into higanworks:rewrite_use_incoming_webhook Aug 18, 2015
@sawanoboly
Copy link
Member

Thanks 😃

@fibbers fibbers deleted the print-group-in-jobname branch August 18, 2015 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants