This repository has been archived by the owner on May 29, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds CommonJS support to this module by detecting the presence of
module.exports
, and if it exists, exporting the factory function instead of calling it on the global Highcharts object. This is in line with how the Highcharts exporting module is used in CommonJS.It also adds a package.json, if this PR gets accepted please publish this module on NPM.
highcharts-
since it is a pluginpeerDependency
since that is how version constraints for plugins should be defined. The homepage mentions at least 3.0 is required, so I set the version constraint between 3.0 and the next major version.This allows one to
require('highcharts-export-csv')(Highcharts)
in a CommonJS environment like Browerify. Global use is still supported.