remove accidental console log (#87)

adds eslint rule to error on console logs
highlight · Aug 5, 2022 · 2174763 · 2174763
1 parent ee5ef11
commit 2174763
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 7 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -19,5 +19,6 @@ module.exports = {
   plugins: ['@typescript-eslint', 'eslint-plugin-tsdoc'],
   rules: {
     'tsdoc/syntax': 'warn',
+    'no-console': 'error',
   },
 };
diff --git a/packages/rrdom-nodejs/package.json b/packages/rrdom-nodejs/package.json
@@ -47,7 +47,7 @@
   },
   "dependencies": {
     "@highlight-run/rrdom": "0.1.17",
-    "@highlight-run/rrweb-snapshot": "1.1.27",
+    "@highlight-run/rrweb-snapshot": "1.1.28",
     "cssom": "^0.5.0",
     "cssstyle": "^2.3.0",
     "nwsapi": "^2.2.0"

diff --git a/packages/rrdom/package.json b/packages/rrdom/package.json
@@ -46,7 +46,7 @@
     "typescript": "^4.7.3"
   },
   "dependencies": {
-    "@highlight-run/rrweb-snapshot": "1.1.27"
+    "@highlight-run/rrweb-snapshot": "1.1.28"
   },
   "gitHead": "d5751f9e6c52a7734597c8595caa763d0f4dd4ad"
 }
diff --git a/packages/rrweb-snapshot/package.json b/packages/rrweb-snapshot/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@highlight-run/rrweb-snapshot",
-  "version": "1.1.27",
+  "version": "1.1.28",
   "description": "rrweb's component to take a snapshot of DOM, aka DOM serializer",
   "scripts": {
     "prepare": "npm run prepack",

diff --git a/packages/rrweb-snapshot/src/snapshot.ts b/packages/rrweb-snapshot/src/snapshot.ts
@@ -1084,8 +1084,6 @@ export function serializeNodeWithId(
     recordChild = recordChild && !serializedNode.needBlock;
     strictPrivacy = !!serializedNode.needBlock;
 
-    console.log('vadim strictPrivacy', { strictPrivacy, enableStrictPrivacy });
-
     /** Highlight Code Begin */
     // Remove the image's src if enableStrictPrivacy.
     if (strictPrivacy && serializedNode.tagName === 'img') {

diff --git a/packages/rrweb/package.json b/packages/rrweb/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@highlight-run/rrweb",
-  "version": "2.1.4",
+  "version": "2.1.5",
   "description": "record and replay the web",
   "scripts": {
     "prepare": "npm run prepack",
@@ -76,7 +76,7 @@
   },
   "dependencies": {
     "@highlight-run/rrdom": "0.1.17",
-    "@highlight-run/rrweb-snapshot": "1.1.27",
+    "@highlight-run/rrweb-snapshot": "1.1.28",
     "@types/css-font-loading-module": "0.0.7",
     "@xstate/fsm": "^1.4.0",
     "base64-arraybuffer": "^1.0.1",