Elixir highlighting is incorrect

[TMSCH]

Hi Highlight team,

Here is an example showcasing the issues of Elixir highlighting. It's taken from reviewable.io UI that uses highlight.js under the hood.

First, highlight.js

Second, my VSCode editor

(there's some custom coloring going on here but I'll focus on the general issues)

What's wrong in highlight.js

• Incorrect namespace highlighting in defmoduledeclaration (different colors when it should be monochrome)
• Incorrect namespace highlighting in code body (monochrome when namespace should be different color)
• require and import statements are not highlighted.
• @moduledoc, @doc, @typedoc incorrectly highlighted as module attributes.
• <- and |> not highlighted.
• with statement not highlighted.

Thanks for looking into this!

[pkaminski]

I'm working on a PR — here are my thoughts so far:

• require, import and with are simply missing; added.
• Module names can be compound (perhaps other names too?); allow . as part of identifier.
• @moduledoc, @doc and @typedoc appear to be defined as module attributes, not sure why it's wrong to highlight them as such?
• As far as I can tell by looking at the CSS class reference and other languages, highlight.js philosophy is not to highlight operators or namespaces. If that's not correct perhaps a maintainer can correct me?
• Found an extra bug where :: and neighbors gets highlighted as symbol; fixed.

If we can clarify my questions above I can open a PR with the fixes. Thanks!

[TMSCH]

• OK
• OK
• You're right, it's OK to keep them highlighted as module attributes.
• Fine not to highlight namespace, as Objective C support #2 is fixed.
• Great :)