Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve highlighting for Elixir. #1835

Merged
merged 2 commits into from
Sep 20, 2018

Conversation

pkaminski
Copy link
Contributor

@pkaminski pkaminski commented Sep 18, 2018

Specifically:

  • Add missing keywords 'require', 'import', and 'with'.
  • Correctly (not) highlight the '::' operator, instead of treating as symbol.
  • Allow for compound names (for modules, but affects other definitions too).

Fixes #1824.

Specifically:
- Add missing keywords 'require', 'import', and 'with'.
- Correctly (not) highlight the '::' operator, instead of treating as symbol.
- Allow for compound names (for modules, but affects other definitions too).
@marcoscaceres
Copy link
Contributor

Few test failed on TravisCI. Could you please check?

@pkaminski
Copy link
Contributor Author

Looks like the shell detection test is failing, perhaps because I added the with keyword and the test fixture has the line Your branch is up-to-date with 'origin/master'.. Is there an easy way to exclude a keyword from contributing to language detection? I see some language definitions with relevance: 0 on rules but not on keywords.

@pkaminski
Copy link
Contributor Author

Never mind, it was indeed the with keyword and I found the docs on how to zero out its relevance. All tests passing now.

@marcoscaceres
Copy link
Contributor

Oh, great work @pkaminski! Thanks for figuring it out!

@marcoscaceres marcoscaceres merged commit da8bd68 into highlightjs:master Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants