(swift) New string grammar #2902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
reviewed
Dec 2, 2020
joshgoebel
reviewed
Dec 2, 2020
joshgoebel
reviewed
Dec 2, 2020
joshgoebel
requested changes
Dec 2, 2020
|
@joshgoebel I've pushed a new version that incorporates your feedback. |
joshgoebel
reviewed
Dec 2, 2020
joshgoebel
reviewed
Dec 2, 2020
joshgoebel
reviewed
Dec 2, 2020
I think this is looking pretty good, feel free to finish it up. |
|
Ready for a final review! |
joshgoebel
reviewed
Dec 3, 2020
|
Is anything blocking this? I see "Changes requested" but no unresolved conversations. |
joshgoebel
approved these changes
Dec 5, 2020
|
@svanimpe Nope. All good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of the grammar for strings in Swift. I’ve implemented the official grammar (https://docs.swift.org/swift-book/ReferenceManual/LexicalStructure.html#grammar_string-literal) and included support for raw strings with up to three hash signs.
I’m submitting this PR as a WIP to get some early feedback, as this is my first contribution. If the grammar looks good, I'll add a suite of unit tests and update the changelog/contributor list.
Fixes #2819 and replaces #2820.